Skip to content

KEP-4192: update the KEP to describe the currently implemented behavior #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 7, 2025
Merged

KEP-4192: update the KEP to describe the currently implemented behavior #5596

merged 6 commits into from
Oct 7, 2025
+73 −39

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Oct 1, 2025

  • One-line PR description: Update the KEP with description how the controller works today
  • Other comments: Also removes a few obsolete goals and improves the general KEP structure

/cc @michaelasp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2025
michaelasp
michaelasp reviewed Oct 1, 2025
View reviewed changes
michaelasp
michaelasp reviewed Oct 1, 2025
View reviewed changes
keps/sig-api-machinery/4192-svm-in-tree/README.md

### Version Skew Strategy
The feature will be enabled by the feature gate `StorageVersionMigrator` on both the _api-server_ and the _kube-controller-manager_. This gate must be set for both components during installation. Otherwise, since the kube-controller-manager is allowed to be one version lower than the api-server, it won't be able to process any StorageVersionMigration resources created by the API server.
The feature will be enabled by the feature gate `StorageVersionMigrator` on the _kube-controller-manager_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one other feature gate that I am not fully certain what it does but seems related, InformerResourceVersion. It seems like all it does is return the last synced rv of an informer but it doesn't seem documented anywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for that particular featuregate, we could just open a PR in k/k GA-ing it based on the comments from https://kubernetes.slack.com/archives/C06S7LHB06B/p1759334861835019.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I think this should effectively just be the removal of that conditional checking for the feature gate.

stlaz added 2 commits October 2, 2025 14:19
@stlaz
KEP-4192: describe the currently implemented SVM behavior
cabd637 
Signed-off-by: Stanislav Láznička <[email protected]>
@stlaz
KEP-4192: update ToC
e316539 
Signed-off-by: Stanislav Láznička <[email protected]>
@michaelasp
Copy link
Contributor

/lgtm
/cc @jpbetz
/cc @enj

@k8s-ci-robot k8s-ci-robot requested review from enj and jpbetz October 7, 2025 20:05
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Oct 7, 2025

/approve
Thanks for reviewing @michaelasp

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 54dac70 into kubernetes:master Oct 7, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@jpbetz jpbetz Awaiting requested review from jpbetz

1 more reviewer

@michaelasp michaelasp michaelasp left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@michaelasp michaelasp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@stlaz @michaelasp @jpbetz @k8s-ci-robot